Make hook status printing configurable with delay#9641
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9641 +/- ##
==========================================
- Coverage 42.17% 42.14% -0.04%
==========================================
Files 583 583
Lines 77160 77220 +60
==========================================
Hits 32541 32541
- Misses 40616 40676 +60
Partials 4003 4003
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
guillep2k
reviewed
Jan 8, 2020
Member
guillep2k
left a comment
guillep2k
left a comment
There was a problem hiding this comment.
I've written a bunch of comments and suggestions, but I'm not sure this is the right approach. I realize you want to be faithful to the previous state, where a dot was printed for each commit that has been checked. But maybe it would be much easier if we'd just print a dot for each second that has passed after the initial delay (with no goroutines or string builders).
zeripath
changed the title
Contributor
Author
|
I've moved to a wrapped writer implementation with a configurable delay. |
lunny
approved these changes
Jan 11, 2020
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Jan 11, 2020
GiteaBot
added
lgtm/done
zeripath
commented
Jan 11, 2020
zeripath
commented
Jan 11, 2020
zeripath
commented
Jan 11, 2020
zeripath
commented
Jan 11, 2020
zeripath
commented
Jan 11, 2020
Member
|
I stopped and restarted the build which seems blocked. |
zeripath
commented
Jan 12, 2020
Contributor
Author
|
@sapk yup that was my fault. The documentation and example for New timer is particularly bad. I even knew about this problem but forgot about it. |
Contributor
Author
|
Make lg-tm work |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jan 12, 2020
* Delay printing hook statuses until after 1 second * Move to a 5s delay, wrapped writer structure and add config * Update cmd/hook.go * Apply suggestions from code review * Update cmd/hook.go Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
zeripath
added a commit
that referenced
this pull request
Jan 12, 2020
* Delay printing hook statuses until after 1 second * Move to a 5s delay, wrapped writer structure and add config * Update cmd/hook.go * Apply suggestions from code review * Update cmd/hook.go Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com> Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 2 configuration options to control printing of push hook status with a configurable delay.
Fix #9610